fpdfsdk/src/fxedit/fxet_pageobjs.cpp - Issue 1745243002: Pass rect by const reference in SetClip_Rect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fxedit/fxet_pageobjs.cpp

Issue 1745243002: Pass rect by const reference in SetClip_Rect(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fxedit/fxet_pageobjs.cpp

diff --git a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp

index d7803311a56e77d4ac50833bda0726ad12285b3e..24bc46329b10e90f59e2c19f91685bc77844d470 100644

--- a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp

+++ b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp

@@ -100,12 +100,9 @@ void IFX_Edit::DrawUnderline(CFX_RenderDevice* pDevice,

if (!rcClip.IsEmpty()) {

CFX_FloatRect rcTemp = rcClip;

pUser2Device->TransformRect(rcTemp);

- FX_RECT rcDevClip;

- rcDevClip.left = (int32_t)rcTemp.left;

- rcDevClip.right = (int32_t)rcTemp.right;

- rcDevClip.top = (int32_t)rcTemp.top;

- rcDevClip.bottom = (int32_t)rcTemp.bottom;

- pDevice->SetClip_Rect(&rcDevClip);

+ pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.top,

+ (int32_t)rcTemp.right,

+ (int32_t)rcTemp.bottom));

}

if (IFX_Edit_Iterator* pIterator = pEdit->GetIterator()) {

@@ -174,12 +171,9 @@ void IFX_Edit::DrawEdit(CFX_RenderDevice* pDevice,

if (!rcClip.IsEmpty()) {

CFX_FloatRect rcTemp = rcClip;

pUser2Device->TransformRect(rcTemp);

- FX_RECT rcDevClip;

- rcDevClip.left = (int32_t)rcTemp.left;

- rcDevClip.right = (int32_t)rcTemp.right;

- rcDevClip.top = (int32_t)rcTemp.top;

- rcDevClip.bottom = (int32_t)rcTemp.bottom;

- pDevice->SetClip_Rect(&rcDevClip);

+ pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.top,

+ (int32_t)rcTemp.right,

+ (int32_t)rcTemp.bottom));

}

if (IFX_Edit_Iterator* pIterator = pEdit->GetIterator()) {

@@ -299,12 +293,8 @@ void IFX_Edit::DrawRichEdit(CFX_RenderDevice* pDevice,

if (!rcClip.IsEmpty()) {

CFX_FloatRect rcTemp = rcClip;

pUser2Device->TransformRect(rcTemp);

- FX_RECT rcDevClip;

- rcDevClip.left = (int32_t)rcTemp.left;

- rcDevClip.right = (int32_t)rcTemp.right;

- rcDevClip.top = (int32_t)rcTemp.top;

- rcDevClip.bottom = (int32_t)rcTemp.bottom;

- pDevice->SetClip_Rect(&rcDevClip);

+ pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.right,

dsinclair 2016/02/29 21:15:26 This should be left, top, right bottom?

Tom Sepez 2016/02/29 21:17:45 Yup. Just noticed that.

+ (int32_t)rcTemp.top, (int32_t)rcTemp.bottom));

}

if (IFX_Edit_Iterator* pIterator = pEdit->GetIterator()) {

« no previous file with comments | « fpdfsdk/src/fpdfview.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp » ('j') | fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp » ('J')