test/ios/framework/iOSFramework/iOSFramework.h - Issue 1745173002: Add support for iOS Frameworks with header maps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/ios/framework/iOSFramework/iOSFramework.h

Issue 1745173002: Add support for iOS Frameworks with header maps. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Fix comment nit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #import <UIKit/UIKit.h>

	2

	3 //! Project version number for iOSFramework.

	4 FOUNDATION_EXPORT double iOSFrameworkVersionNumber;
	sdefresne 2016/03/18 15:59:00 Can you define your own export macros instead of r Can you define your own export macros instead of reusing those from Foundation/Foundation.h. See https://code.google.com/p/chromium/codesearch#chromium/src/base/base_export.h... for an example (you can probably remove all Win32 support). justincohen 2016/03/19 03:57:00 This is a template file generated by Xcode based o Show quoted text On 2016/03/18 15:59:00, sdefresne wrote: > Can you define your own export macros instead of reusing those from > Foundation/Foundation.h. > > See > https://code.google.com/p/chromium/codesearch#chromium/src/base/base_export.h... > for an example (you can probably remove all Win32 support). This is a template file generated by Xcode based on the framework name (iOSFramework). I'm going to leave as is since this is exactly what Xcode does.
	5

	6 //! Project version string for iOSFramework.

	7 FOUNDATION_EXPORT const unsigned char iOSFrameworkVersionString[];

OLD	NEW