Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: src/deoptimizer.cc

Issue 17451014: Use +kCallerSPOffset instead of -kMarkerOffset to compute the args pointer (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1493 matching lines...) Expand 10 before | Expand all | Expand 10 after
1504 value = arg_count_known ? caller_arg_count : the_hole; 1504 value = arg_count_known ? caller_arg_count : the_hole;
1505 output_frame->SetFrameSlot(length_frame_offset, value); 1505 output_frame->SetFrameSlot(length_frame_offset, value);
1506 if (trace_) { 1506 if (trace_) {
1507 PrintF(" 0x%08" V8PRIxPTR ": [top + %d] <- 0x%08" 1507 PrintF(" 0x%08" V8PRIxPTR ": [top + %d] <- 0x%08"
1508 V8PRIxPTR " ; args.length %s\n", 1508 V8PRIxPTR " ; args.length %s\n",
1509 top_address + length_frame_offset, length_frame_offset, value, 1509 top_address + length_frame_offset, length_frame_offset, value,
1510 arg_count_known ? "" : "(the hole)"); 1510 arg_count_known ? "" : "(the hole)");
1511 } 1511 }
1512 1512
1513 output_frame_offset -= kPointerSize; 1513 output_frame_offset -= kPointerSize;
1514 value = frame_ptr - (output_frame_size - output_frame_offset) - 1514 value = frame_ptr + StandardFrameConstants::kCallerSPOffset -
1515 StandardFrameConstants::kMarkerOffset + kPointerSize; 1515 (output_frame_size - output_frame_offset) + kPointerSize;
1516 output_frame->SetFrameSlot(output_frame_offset, value); 1516 output_frame->SetFrameSlot(output_frame_offset, value);
1517 if (trace_) { 1517 if (trace_) {
1518 PrintF(" 0x%08" V8PRIxPTR ": [top + %d] <- 0x%08" 1518 PrintF(" 0x%08" V8PRIxPTR ": [top + %d] <- 0x%08"
1519 V8PRIxPTR " ; args*\n", 1519 V8PRIxPTR " ; args*\n",
1520 top_address + output_frame_offset, output_frame_offset, value); 1520 top_address + output_frame_offset, output_frame_offset, value);
1521 } 1521 }
1522 1522
1523 // Copy the register parameters to the failure frame. 1523 // Copy the register parameters to the failure frame.
1524 for (int i = 0; i < descriptor->register_param_count_; ++i) { 1524 for (int i = 0; i < descriptor->register_param_count_; ++i) {
1525 output_frame_offset -= kPointerSize; 1525 output_frame_offset -= kPointerSize;
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
3110 3110
3111 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) { 3111 void DeoptimizedFrameInfo::Iterate(ObjectVisitor* v) {
3112 v->VisitPointer(BitCast<Object**>(&function_)); 3112 v->VisitPointer(BitCast<Object**>(&function_));
3113 v->VisitPointers(parameters_, parameters_ + parameters_count_); 3113 v->VisitPointers(parameters_, parameters_ + parameters_count_);
3114 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_); 3114 v->VisitPointers(expression_stack_, expression_stack_ + expression_count_);
3115 } 3115 }
3116 3116
3117 #endif // ENABLE_DEBUGGER_SUPPORT 3117 #endif // ENABLE_DEBUGGER_SUPPORT
3118 3118
3119 } } // namespace v8::internal 3119 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698