chrome/renderer/resources/extensions/utils.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/utils.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/unload_event.js ('k') | chrome/renderer/resources/extensions/web_request_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/utils.js

diff --git a/chrome/renderer/resources/extensions/utils.js b/chrome/renderer/resources/extensions/utils.js

index 45d929552b511d584d24523c0934b253c1208db4..80b5f1beaf72876884faf6c4cc9d0815a9f1c2bf 100644

--- a/chrome/renderer/resources/extensions/utils.js

+++ b/chrome/renderer/resources/extensions/utils.js

@@ -32,7 +32,7 @@ function lookup(array_of_dictionaries, field, value) {

}

function loadTypeSchema(typeName, defaultSchema) {

- var parts = typeName.split('.');

+ var parts = $String.split(typeName, '.');

if (parts.length == 1) {

if (defaultSchema == null) {

WARNING('Trying to reference "' + typeName + '" ' +

@@ -41,7 +41,7 @@ function loadTypeSchema(typeName, defaultSchema) {

}

var types = defaultSchema.types;

} else {

- var schemaName = parts.slice(0, parts.length - 1).join('.')

+ var schemaName = $Array.join($Array.slice(parts, 0, parts.length - 1), '.');

var types = schemaRegistry.GetSchema(schemaName).types;

}

for (var i = 0; i < types.length; ++i) {