Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7530)

Unified Diff: chrome/renderer/resources/extensions/schema_utils.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/schema_utils.js
diff --git a/chrome/renderer/resources/extensions/schema_utils.js b/chrome/renderer/resources/extensions/schema_utils.js
index 5ec93fc5503871615a928f159852262704ef6f41..d54fbe203131821701891913d792a12800fde6a3 100644
--- a/chrome/renderer/resources/extensions/schema_utils.js
+++ b/chrome/renderer/resources/extensions/schema_utils.js
@@ -44,11 +44,11 @@ function getSignatures(parameterSchemas) {
if (parameterSchemas.length === 0)
return [[]];
var signatures = [];
- var remaining = getSignatures(parameterSchemas.slice(1));
+ var remaining = getSignatures($Array.slice(parameterSchemas, 1));
for (var i = 0; i < remaining.length; i++)
- signatures.push([parameterSchemas[0]].concat(remaining[i]))
+ $Array.push(signatures, $Array.concat([parameterSchemas[0]], remaining[i]))
if (parameterSchemas[0].optional)
- return signatures.concat(remaining);
+ return $Array.concat(signatures, remaining);
return signatures;
};
@@ -119,9 +119,9 @@ function normalizeArgumentsAndValidate(args, funDef) {
var ai = 0;
for (var si = 0; si < definedSignature.length; si++) {
if (definedSignature[si] === resolvedSignature[ai])
- normalizedArgs.push(args[ai++]);
+ $Array.push(normalizedArgs, args[ai++]);
else
- normalizedArgs.push(null);
+ $Array.push(normalizedArgs, null);
}
return normalizedArgs;
};
« no previous file with comments | « chrome/renderer/resources/extensions/platform_app.js ('k') | chrome/renderer/resources/extensions/searchbox_api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698