chrome/renderer/resources/extensions/omnibox_custom_bindings.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/notifications_custom_bindings.js ('k') | chrome/renderer/resources/extensions/permissions_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

index 2fd7a6c58c7bcae96650ecf2fe971abfaf8a509e..6e753a97b104df0088f58c07329b8dbf4c71bd0a 100644

--- a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

@@ -65,7 +65,7 @@ function parseOmniboxDescription(input) {

'type': child.nodeName,

'offset': result.description.length

};

- result.descriptionStyles.push(style);

+ $Array.push(result.descriptionStyles, style);

walk(child);

style.length = result.description.length - style.offset;

continue;

@@ -105,7 +105,7 @@ binding.registerCustomHook(function(bindingsAPI) {

var parseResult = parseOmniboxDescription(

userSuggestions[i].description);

parseResult.content = userSuggestions[i].content;

- suggestions.push(parseResult);

+ $Array.push(suggestions, parseResult);

}

return [requestId, suggestions];

});