Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: chrome/renderer/resources/extensions/miscellaneous_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/miscellaneous_bindings.js
diff --git a/chrome/renderer/resources/extensions/miscellaneous_bindings.js b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
index 52a75505a293dfd113dc43835bef57003c71ef37..14b83badddb9b88ec17d85e5a8bbfb6c416056ef 100644
--- a/chrome/renderer/resources/extensions/miscellaneous_bindings.js
+++ b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
@@ -101,19 +101,19 @@
var errorMsg = [];
var eventName = isSendMessage ? "runtime.onMessage" : "extension.onRequest";
if (isSendMessage && !responseCallbackPreserved) {
- errorMsg.push(
+ $Array.push(errorMsg,
"The chrome." + eventName + " listener must return true if you " +
"want to send a response after the listener returns");
} else {
- errorMsg.push(
+ $Array.push(errorMsg,
"Cannot send a response more than once per chrome." + eventName +
" listener per document");
}
- errorMsg.push("(message was sent by extension" + sourceExtensionId);
+ $Array.push(errorMsg, "(message was sent by extension" + sourceExtensionId);
if (sourceExtensionId != "" && sourceExtensionId != targetExtensionId)
- errorMsg.push("for extension " + targetExtensionId);
+ $Array.push(errorMsg, "for extension " + targetExtensionId);
if (sourceUrl != "")
- errorMsg.push("for URL " + sourceUrl);
+ $Array.push(errorMsg, "for URL " + sourceUrl);
lastError.set(eventName, errorMsg.join(" ") + ").", null, chrome);
}
@@ -318,7 +318,7 @@
// schema validation is expecting, e.g.
// extension.sendRequest(req) -> extension.sendRequest(null, req)
// extension.sendRequest(req, cb) -> extension.sendRequest(null, req, cb)
- var args = Array.prototype.splice.call(arguments, 1); // skip functionName
+ var args = $Array.splice(arguments, 1); // skip functionName
var lastArg = args.length - 1;
// responseCallback (last argument) is optional.

Powered by Google App Engine
This is Rietveld 408576698