chrome/renderer/resources/extensions/last_error.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/last_error.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/json_schema.js ('k') | chrome/renderer/resources/extensions/media_galleries_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/last_error.js

diff --git a/chrome/renderer/resources/extensions/last_error.js b/chrome/renderer/resources/extensions/last_error.js

index 42e5dd8bc90701d14efa3cc45047048199921cfa..7252a2e15ced294d21fd0dad195cefe98f7690e0 100644

--- a/chrome/renderer/resources/extensions/last_error.js

+++ b/chrome/renderer/resources/extensions/last_error.js

@@ -54,7 +54,7 @@ function run(name, message, stack, callback, args) {

var targetChrome = GetGlobal(callback).chrome;

set(name, message, stack, targetChrome);

try {

- callback.apply(undefined, args);

+ $Function.apply(callback, undefined, args);

} finally {

clear(targetChrome);

}