chrome/renderer/resources/extensions/image_util.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/image_util.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/i18n_custom_bindings.js ('k') | chrome/renderer/resources/extensions/json_schema.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/image_util.js

diff --git a/chrome/renderer/resources/extensions/image_util.js b/chrome/renderer/resources/extensions/image_util.js

index 7075c94cf1fc730b9f030d62e7b118559b30394f..79867404af3debe9d11598b8214de822b9389ccd 100644

--- a/chrome/renderer/resources/extensions/image_util.js

+++ b/chrome/renderer/resources/extensions/image_util.js

@@ -60,7 +60,7 @@ function on_complete_index(index, err, loading, finished, callbacks) {

finished[index] = { width: width, height: height, data: imageData };

if (err)

callbacks.onerror(index);

- if (Object.keys(loading).length == 0)

+ if ($Object.keys(loading).length == 0)

callbacks.oncomplete(finished);

}