chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/extension_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js b/chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js

index 7903a3d3d8b5930f101167adf6ba4550c703747a..394f191f48ff3d07a9ef694fadfe9111f7aec742 100644

--- a/chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js

@@ -45,8 +45,10 @@ binding.registerCustomHook(

// We are making a copy of |arr|, but applying |func| to index 1.

function validate(arr, func) {

var newArr = [];

- for (var i = 0; i < arr.length; i++)

- newArr.push(i == 1 && typeof(arr) == 'object' ? func(arr[i]) : arr[i]);

+ for (var i = 0; i < arr.length; i++) {

+ $Array.push(newArr,

+ i == 1 && typeof(arr) == 'object' ? func(arr[i]) : arr[i]);

+ }

return newArr;

}

« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/extension_custom_bindings.js » ('j') | no next file with comments »