chrome/renderer/resources/extensions/content_watcher.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/content_watcher.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/content_setting.js ('k') | chrome/renderer/resources/extensions/context_menus_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/content_watcher.js

diff --git a/chrome/renderer/resources/extensions/content_watcher.js b/chrome/renderer/resources/extensions/content_watcher.js

index c060276608cd3b108b203bcb373125cc9f0c4979..6005a786096a1ce6b58848a16732bcf15f99a085 100644

--- a/chrome/renderer/resources/extensions/content_watcher.js

+++ b/chrome/renderer/resources/extensions/content_watcher.js

@@ -10,7 +10,7 @@ exports.FindMatchingSelectors = function(cssSelectors) {

$Array.forEach(cssSelectors, function(selector, index) {

try {

if (document.querySelector(selector) != null)

- result.push(index);

+ $Array.push(result, index);

} catch (exception) {

throw new Error("query Selector failed on '" + selector + "': " +

exception.stack);