chrome/renderer/resources/extensions/chrome_setting.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/chrome_setting.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/bluetooth_custom_bindings.js ('k') | chrome/renderer/resources/extensions/content_setting.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/chrome_setting.js

diff --git a/chrome/renderer/resources/extensions/chrome_setting.js b/chrome/renderer/resources/extensions/chrome_setting.js

index b2194b12ac718f880f64bc7aa896f74b6ac5b5e2..8d6f29e3fd2911d06bdd374ee2a6f976dc2870b1 100644

--- a/chrome/renderer/resources/extensions/chrome_setting.js

+++ b/chrome/renderer/resources/extensions/chrome_setting.js

@@ -7,7 +7,7 @@ var sendRequest = require('sendRequest').sendRequest;

var validate = require('schemaUtils').validate;

function extendSchema(schema) {

- var extendedSchema = schema.slice();

+ var extendedSchema = $Array.slice(schema);

extendedSchema.unshift({'type': 'string'});

return extendedSchema;

}

@@ -21,7 +21,8 @@ function ChromeSetting(prefKey, valueSchema) {

extendSchema(getSchema));

};

this.set = function(details, callback) {

- var setSchema = this.functionSchemas.set.definition.parameters.slice();

+ var setSchema = $Array.slice(

+ this.functionSchemas.set.definition.parameters);

setSchema[0].properties.value = valueSchema;

validate([details, callback], setSchema);

return sendRequest('types.ChromeSetting.set',