chrome/renderer/resources/extensions/app_custom_bindings.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/app_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/ad_view.js ('k') | chrome/renderer/resources/extensions/app_runtime_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/app_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/app_custom_bindings.js b/chrome/renderer/resources/extensions/app_custom_bindings.js

index 2bc8690b09d56c4a5dfe0e5485eae2657478d717..733395d574dcbf95ad30abfdef2175e6fab35d99 100644

--- a/chrome/renderer/resources/extensions/app_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/app_custom_bindings.js

@@ -22,8 +22,8 @@ function wrapForLogging(fun) {

// TODO(ataly): We need to make sure we use the right prototype for

// fun.apply. Array slice can either be rewritten or similarly defined.

logActivity.LogAPICall(id, "app." + fun.name,

- Array.prototype.slice.call(arguments));

- return fun.apply(this, arguments);

+ $Array.slice(arguments));

+ return $Function.apply(fun, this, arguments);

});

}