Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4217)

Unified Diff: chrome/renderer/resources/extensions/permissions_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hopefully fix tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/permissions_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/permissions_custom_bindings.js b/chrome/renderer/resources/extensions/permissions_custom_bindings.js
index 7ff85f5cacda17d6e5b97efb32cb5d968c2cc607..244fd957708357faa2433166ee3d78e6067b2df8 100644
--- a/chrome/renderer/resources/extensions/permissions_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/permissions_custom_bindings.js
@@ -21,7 +21,7 @@ binding.registerCustomHook(function(api) {
var permissions = api.compiledApi;
function maybeConvertToObject(str) {
- var parts = str.split('|');
+ var parts = $String.split(str, '|');
if (parts.length != 2)
return str;
@@ -41,7 +41,7 @@ binding.registerCustomHook(function(api) {
for (var i = 0; i < args.length; i += 1) {
if (typeof(args[i]) == 'object') {
var a = args[i];
- var keys = Object.keys(a);
+ var keys = $Object.keys(a);
if (keys.length != 1) {
throw new Error("Too many keys in object-style permission.");
}
@@ -75,7 +75,7 @@ binding.registerCustomHook(function(api) {
// that handleResponse doesn't call it again.
try {
if (request.callback)
- request.callback.apply(request, [response]);
+ $Function.apply(request.callback, request, [response]);
} finally {
delete request.callback;
}

Powered by Google App Engine
This is Rietveld 408576698