chrome/renderer/resources/extensions/notifications_custom_bindings.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/notifications_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: hopefully fix tests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/safe_builtins.cc ('K') | « chrome/renderer/resources/extensions/miscellaneous_bindings.js ('k') | chrome/renderer/resources/extensions/omnibox_custom_bindings.js » ('j') | chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/notifications_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/notifications_custom_bindings.js b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

index fb19ac40350d5f346ba8c9ecf336f6fdbbe9d9d2..5150a4fb1e4b1a8ee3d7a63f052b9e1394c4e216 100644

--- a/chrome/renderer/resources/extensions/notifications_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/notifications_custom_bindings.js

@@ -36,7 +36,7 @@ function replaceNotificationOptionURLs(notification_details, callback) {

// |imageUrl| is optional.

if (notification_details.imageUrl) {

- url_specs.push({

+ $Array.push(url_specs, {

path: notification_details.imageUrl,

width: 360,

height: 540,

@@ -50,7 +50,7 @@ function replaceNotificationOptionURLs(notification_details, callback) {

var num_buttons = button_list.length;

for (var i = 0; i < num_buttons; i++) {

if (button_list[i].iconUrl) {

- url_specs.push({

+ $Array.push(url_specs, {

path: button_list[i].iconUrl,

width: 16,

height: 16,