chrome/renderer/resources/extensions/media_galleries_custom_bindings.js - Issue 17451011: Make the externally connectable browser test clobber all of the builtins,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

Issue 17451011: Make the externally connectable browser test clobber all of the builtins, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: hopefully fix tests Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/safe_builtins.cc ('K') | « chrome/renderer/resources/extensions/last_error.js ('k') | chrome/renderer/resources/extensions/miscellaneous_bindings.js » ('j') | chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js b/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

index 93e0a34c986f0609a2fff25dac544bb16e40dd3a..e741fea173fc8522b3ba9c7259cfec79178cb9d2 100644

--- a/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

@@ -24,7 +24,7 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {

for (var i = 0; i < response.length; i++) {

var filesystem = mediaGalleriesNatives.GetMediaFileSystemObject(

response[i].fsid);

- result.push(filesystem);

+ $Array.push(result, filesystem);

var metadata = response[i];

delete metadata.fsid;

mediaGalleriesMetadata[filesystem.name] = metadata;