Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1745073002: DM: disable ignored and very niche configs on bots. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: disable ignored and very niche configs on bots. These are all probably just wasting time: - upright-matrix-{8888,gpu} and remote[_cache] are ignored in Gold - sp and 2ndpic test very niche areas of SkPicture that are not under active change - twice-8888 was never useful... the twice- via was meant for local testing of GPU batching / caching. Drawing into 8888 was moot. These configs are all useful to keep around for local testing, but probably are not worth the extra runtime or especially burden to have to think about them. If we should happen to stumble into bugs these configs would have caught, let's add them back with a note about those bugs to justify their need to run. I'm not convinced any exist today. This cuts ~30s off the CQ. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745073002 Committed: https://skia.googlesource.com/skia/+/7b6d3a30cf18377935c800603fc00fe0966d15de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -869 lines) Patch
M tools/dm_flags.json View 18 chunks +9 lines, -853 lines 0 comments Download
M tools/dm_flags.py View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745073002/1
4 years, 9 months ago (2016-02-29 15:22:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 15:43:03 UTC) #5
mtklein_C
4 years, 9 months ago (2016-02-29 16:16:31 UTC) #8
hal.canary
lgtm
4 years, 9 months ago (2016-02-29 16:23:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745073002/1
4 years, 9 months ago (2016-02-29 16:51:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7b6d3a30cf18377935c800603fc00fe0966d15de
4 years, 9 months ago (2016-02-29 16:52:31 UTC) #13
mtklein
4 years, 9 months ago (2016-02-29 17:50:54 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1749583003/ by mtklein@google.com.

The reason for reverting is: remote-8888 just caught a bug.  I am disproved..

Powered by Google App Engine
This is Rietveld 408576698