Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1745063002: Render batch bounds as stroke rects (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -9 lines) Patch
M include/private/GrAuditTrail.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 5 chunks +61 lines, -1 line 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tools/skiaserve/urlhandlers/BatchBoundsHandler.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
ptal
4 years, 9 months ago (2016-02-29 15:56:29 UTC) #3
ethannicholas
lgtm
4 years, 9 months ago (2016-02-29 18:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745063002/40001
4 years, 9 months ago (2016-02-29 18:54:37 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 19:15:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/10d8fc29bc1605c134e98f5b58c2efb73cef6073

Powered by Google App Engine
This is Rietveld 408576698