Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745023003: Remove xfa_fm2js.h and IWYU. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -48 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/libfuzzer/pdf_fm2js_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/common/xfa_fm2jsapi.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_error.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_error.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_expression.cpp View 1 chunk +5 lines, -1 line 0 comments Download
D xfa/src/fxfa/src/fm2js/xfa_fm2js.h View 1 chunk +0 lines, -32 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jsapi.cpp View 1 1 chunk +8 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fmparse.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_lexer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_lexer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_program.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_program.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_simpleexpression.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL. https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h File xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h (right): https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h#newcode13 xfa/src/fxfa/src/fm2js/xfa_simpleexpression.h:13: #define RUNTIMEFUNCTIONRETURNVALUE \ These are used here and ...
4 years, 9 months ago (2016-02-29 20:08:15 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_error.cpp File xfa/src/fxfa/src/fm2js/xfa_error.cpp (right): https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_error.cpp#newcode9 xfa/src/fxfa/src/fm2js/xfa_error.cpp:9: static const FX_WCHAR* gs_lpStrErrorMsgInfo[] = { nit: static ...
4 years, 9 months ago (2016-02-29 20:17:03 UTC) #3
dsinclair
https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_error.cpp File xfa/src/fxfa/src/fm2js/xfa_error.cpp (right): https://codereview.chromium.org/1745023003/diff/1/xfa/src/fxfa/src/fm2js/xfa_error.cpp#newcode9 xfa/src/fxfa/src/fm2js/xfa_error.cpp:9: static const FX_WCHAR* gs_lpStrErrorMsgInfo[] = { On 2016/02/29 20:17:03, ...
4 years, 9 months ago (2016-02-29 21:10:22 UTC) #4
dsinclair
4 years, 9 months ago (2016-02-29 21:10:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3f157c7c6a5cdb92dd5df2a0b06c10ed83b472e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698