Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745023002: Disable flaky SampleWhenFrameIsNotSetup (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable flaky SampleWhenFrameIsNotSetup BUG=v8:2999, v8:4751 LOG=n Committed: https://crrev.com/4d659edfcdbfdd3bf3204802121d08473e08dcbf Cr-Commit-Position: refs/heads/master@{#34360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-02-29 11:51:03 UTC) #2
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-02-29 11:52:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745023002/1
4 years, 9 months ago (2016-02-29 11:52:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11636)
4 years, 9 months ago (2016-02-29 11:57:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745023002/1
4 years, 9 months ago (2016-02-29 11:58:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 12:13:36 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 12:14:24 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d659edfcdbfdd3bf3204802121d08473e08dcbf
Cr-Commit-Position: refs/heads/master@{#34360}

Powered by Google App Engine
This is Rietveld 408576698