Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1745013002: [runtime] inline fast-path ToName (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] inline fast-path ToName, ToUint32 (used by ToArrayIndex) This speeds up hasOwnProperty 5-10% BUG= Committed: https://crrev.com/dd6f62e6cecb333411ef27d4e7d0ab9a8ffa3fa8 Cr-Commit-Position: refs/heads/master@{#34362}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M src/objects.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/objects.cc View 1 3 chunks +10 lines, -30 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-02-29 12:54:00 UTC) #3
Camillo Bruni
lgtm
4 years, 9 months ago (2016-02-29 12:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745013002/20001
4 years, 9 months ago (2016-02-29 12:56:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 13:19:07 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 13:20:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd6f62e6cecb333411ef27d4e7d0ab9a8ffa3fa8
Cr-Commit-Position: refs/heads/master@{#34362}

Powered by Google App Engine
This is Rietveld 408576698