Source/core/css/parser/BisonCSSParser-in.cpp - Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed compilation error in mac and crash in linux/window that were reported by trybots. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/BisonCSSParser-in.cpp

diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp

index b9528d17cdfaf708ea531771ceb71b1078a667cb..686a28f00ab169fa273b1205f26caee4b43a5f59 100644

--- a/Source/core/css/parser/BisonCSSParser-in.cpp

+++ b/Source/core/css/parser/BisonCSSParser-in.cpp

@@ -412,6 +412,11 @@ bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, CSSValueID valueID

// See section CSS_PROP_LIST_STYLE_TYPE of file CSSValueKeywords.in

// for the list of supported list-style-types.

return (valueID >= CSSValueDisc && valueID <= CSSValueKatakanaIroha) || valueID == CSSValueNone;

+ case CSSPropertyNavDown:

Timothy Loh 2014/10/01 13:14:53 This is unreachable. We'd only get here is these v

+ case CSSPropertyNavLeft:

+ case CSSPropertyNavRight:

+ case CSSPropertyNavUp: // current | root

+ return valueID == CSSValueCurrent || valueID == CSSValueRoot;

case CSSPropertyObjectFit:

return valueID == CSSValueFill || valueID == CSSValueContain || valueID == CSSValueCover || valueID == CSSValueNone || valueID == CSSValueScaleDown;

case CSSPropertyOutlineStyle: // (<border-style> except hidden) | auto

« Source/core/css/CSSProperties.in ('K') | « Source/core/css/CSSValueKeywords.in ('k') | Source/core/css/parser/CSSGrammar.y » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')