Source/core/css/CSSCalculationValue.cpp - Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed compilation error in mac and crash in linux/window that were reported by trybots. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/spatial-navigation/snav-css-nav-direction.html ('K') | « Source/core/core.gypi ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index d87a391095934fc0463db83e5b9a357f190ff065..3c7b32d35b6e374b363466e65f258209e46bb916 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -129,6 +129,7 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitType type)

case CSSPrimitiveValue::CSS_PAIR:

case CSSPrimitiveValue::CSS_UNICODE_RANGE:

case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:

+ case CSSPrimitiveValue::CSS_PARSER_IDSEL:

case CSSPrimitiveValue::CSS_COUNTER_NAME:

case CSSPrimitiveValue::CSS_SHAPE:

case CSSPrimitiveValue::CSS_QUAD: