Source/core/css/CSSCalculationValue.cpp - Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied code review suggestions. Also rebased. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index fdbddc6299ed824ead24b628cea85743abe8b86f..28cb229e3c729a66e116c791f2a25fba3800b0b6 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -121,6 +121,7 @@ static bool hasDoubleValue(CSSPrimitiveValue::UnitTypes type)

case CSSPrimitiveValue::CSS_PARSER_OPERATOR:

case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:

case CSSPrimitiveValue::CSS_PARSER_IDENTIFIER:

+ case CSSPrimitiveValue::CSS_PARSER_IDSEL:

case CSSPrimitiveValue::CSS_TURN:

case CSSPrimitiveValue::CSS_COUNTER_NAME:

case CSSPrimitiveValue::CSS_SHAPE:

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')