Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/CSSComputedStyleDeclaration.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
+ * Copyright (C) 2013 Opera Software ASA. All rights reserved.

[fs, 2014/04/14 12:32:01]

Update year. (In all files where it's been added.)

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
@@ skipping 128 matching lines @@
     CSSPropertyListStylePosition,
     CSSPropertyListStyleType,
     CSSPropertyMarginBottom,
     CSSPropertyMarginLeft,
     CSSPropertyMarginRight,
     CSSPropertyMarginTop,
     CSSPropertyMaxHeight,
     CSSPropertyMaxWidth,
     CSSPropertyMinHeight,
     CSSPropertyMinWidth,
+    CSSPropertyNavDown,
+    CSSPropertyNavLeft,
+    CSSPropertyNavRight,
+    CSSPropertyNavUp,
     CSSPropertyMixBlendMode,
     CSSPropertyObjectFit,
     CSSPropertyObjectPosition,
     CSSPropertyOpacity,
     CSSPropertyOrphans,
     CSSPropertyOutlineColor,
     CSSPropertyOutlineOffset,
     CSSPropertyOutlineStyle,
     CSSPropertyOutlineWidth,
     CSSPropertyOverflowWrap,
@@ skipping 1190 matching lines @@
 
     RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
     for (CounterDirectiveMap::const_iterator it = map->begin(); it != map->end(); ++it) {
         list->append(cssValuePool().createValue(it->key, CSSPrimitiveValue::CSS_STRING));
         short number = propertyID == CSSPropertyCounterIncrement ? it->value.incrementValue() : it->value.resetValue();
         list->append(cssValuePool().createValue((double)number, CSSPrimitiveValue::CSS_NUMBER));
     }
     return list.release();
 }
 
+static PassRefPtr<CSSValue> valueForNavigationDirection(const RenderStyle& style, CSSPropertyID propertyID)

[fs, 2014/04/14 12:32:01]

The return type should now be PassRefPtrWillBeRawPtr<CSSValue> (for Oilpan
compat.)

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+{
+    StyleNavigationValue navValue;
+
+    if (StyleNavigationData* navigationData = style.navigation()) {
+        switch (propertyID) {
+        case CSSPropertyNavUp:
+            navValue = navigationData->up();
+            break;
+        case CSSPropertyNavDown:
+            navValue = navigationData->down();
+            break;
+        case CSSPropertyNavLeft:
+            navValue = navigationData->left();
+            break;
+        case CSSPropertyNavRight:
+            navValue = navigationData->right();
+            break;
+        default:
+            ASSERT_NOT_REACHED();
+            break;
+        }
+    }
+    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

[fs, 2014/04/14 12:32:01]

...WillBeRawPtr (like above.)

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+    list->append(cssValuePool().createValue(navValue.id(), CSSPrimitiveValue::CSS_STRING));

[fs, 2014/04/14 12:32:01]

Spec says: "Computed value: as specified", so I'd expect the possibility of
'auto' here. Maybe add some basic tests for this?

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+    list->append(cssValuePool().createValue(navValue.target(), CSSPrimitiveValue::CSS_STRING));
+
+    return list.release();
+}
+
 static void logUnimplementedPropertyID(CSSPropertyID propertyID)
 {
     DEFINE_STATIC_LOCAL(HashSet<CSSPropertyID>, propertyIDSet, ());
     if (!propertyIDSet.add(propertyID).isNewEntry)
         return;
 
     WTF_LOG_ERROR("WebKit does not yet implement getComputedStyle for '%s'.", getPropertyName(propertyID));
 }
 
 static PassRefPtrWillBeRawPtr<CSSValueList> valueForFontFamily(RenderStyle& style)
@@ skipping 694 matching lines @@
             if (marginBottom.isFixed() || !renderer || !renderer->isBox())
                 return zoomAdjustedPixelValueForLength(marginBottom, *style);
             return zoomAdjustedPixelValue(toRenderBox(renderer)->marginBottom(), *style);
         }
         case CSSPropertyMarginLeft: {
             Length marginLeft = style->marginLeft();
             if (marginLeft.isFixed() || !renderer || !renderer->isBox())
                 return zoomAdjustedPixelValueForLength(marginLeft, *style);
             return zoomAdjustedPixelValue(toRenderBox(renderer)->marginLeft(), *style);
         }
+        case CSSPropertyNavDown:
+        case CSSPropertyNavLeft:
+        case CSSPropertyNavRight:
+        case CSSPropertyNavUp:
+            return valueForNavigationDirection(*style, propertyID);
         case CSSPropertyWebkitUserModify:
             return cssValuePool().createValue(style->userModify());
         case CSSPropertyMaxHeight: {
             const Length& maxHeight = style->maxHeight();
             if (maxHeight.isUndefined())
                 return cssValuePool().createIdentifierValue(CSSValueNone);
             return zoomAdjustedPixelValueForLength(maxHeight, *style);
         }
         case CSSPropertyMaxWidth: {
             const Length& maxWidth = style->maxWidth();
@@ skipping 958 matching lines @@
     static const CSSPropertyID propertiesAfterSlashSeperator[3] = { CSSPropertyBackgroundSize, CSSPropertyBackgroundOrigin,
                                                                     CSSPropertyBackgroundClip };
 
     RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSlashSeparated();
     list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBackground, propertiesBeforeSlashSeperator, WTF_ARRAY_LENGTH(propertiesBeforeSlashSeperator))));
     list->append(valuesForShorthandProperty(StylePropertyShorthand(CSSPropertyBackground, propertiesAfterSlashSeperator, WTF_ARRAY_LENGTH(propertiesAfterSlashSeperator))));
     return list.release();
 }
 
 } // namespace WebCore