Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/resolver/StyleResolver.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Opera Software ASA. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
@@ skipping 2666 matching lines @@
     case CSSPropertyWebkitMaskRepeat:
     case CSSPropertyWebkitTextEmphasis:
     case CSSPropertyWebkitTextStroke:
     case CSSPropertyWebkitTransition:
     case CSSPropertyWebkitTransformOrigin:
         ASSERT(isExpandedShorthand(id));
         ASSERT_NOT_REACHED();
         break;
 
     // CSS3 Properties
+    case CSSPropertyNavDown:
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp: {
+        NavDirSetter setter = getNavDirSetterForProperty(id);
+
+        if (isInitial) {
+            (m_state.style()->*setter)(StyleNavigationValue());
+        } else if (primitiveValue) {
+            (m_state.style()->*setter)(StyleNavigationValue(primitiveValue->getStringValue()));
+        } else if (value->isValueList()) {
+            AtomicString vals[2];
+            CSSValueListIterator iterator = value;
+
+            for (int i = 0; i < 2 && iterator.hasMore(); iterator.advance()) {
+                CSSValue* item = iterator.value();
+                if (!item->isPrimitiveValue())
+                    continue;
+                vals[i++] = (static_cast<CSSPrimitiveValue*>(item))->getStringValue();
+            }
+
+            (m_state.style()->*setter)(StyleNavigationValue(vals[0], vals[1]));

[esprehn, 2013/06/20 19:45:10]

You should do this the other way around instead of using function pointers with
a separate switch, this switch statement should be:

case CSSPropertyNavDown:
  style->setNavDown(spatialNavigationValue(...));
  break;
case CSSPropertyNavUp:
  ...

[Krzysztof Olczyk, 2013/07/22 14:14:16]

Done.

+        }
+        return;
+    }
     case CSSPropertyTextShadow:
     case CSSPropertyBoxShadow:
     case CSSPropertyWebkitBoxShadow: {
         if (isInherit) {
             if (id == CSSPropertyTextShadow)
                 return state.style()->setTextShadow(state.parentStyle()->textShadow() ? adoptPtr(new ShadowData(*state.parentStyle()->textShadow())) : nullptr);
             return state.style()->setBoxShadow(state.parentStyle()->boxShadow() ? adoptPtr(new ShadowData(*state.parentStyle()->boxShadow())) : nullptr);
         }
         if (isInitial || primitiveValue) // initial | none
             return id == CSSPropertyTextShadow ? state.style()->setTextShadow(nullptr) : state.style()->setBoxShadow(nullptr);
@@ skipping 825 matching lines @@
                     CSSShaderValue* shaderValue = static_cast<StylePendingShader*>(program->fragmentShader())->cssShaderValue();
                     program->setFragmentShader(shaderValue->cachedShader(cachedResourceLoader));
                 }
                 m_customFilterProgramCache->add(program);
             }
         }
     }
     m_state.setHasPendingShaders(false);
 }
 
+StyleResolver::NavDirSetter StyleResolver::getNavDirSetterForProperty(CSSPropertyID id)
+{
+    switch (id) {
+    case CSSPropertyNavDown:
+        return &RenderStyle::setNavDown;
+    case CSSPropertyNavLeft:
+        return &RenderStyle::setNavLeft;
+    case CSSPropertyNavRight:
+        return &RenderStyle::setNavRight;
+    case CSSPropertyNavUp:
+        return &RenderStyle::setNavUp;
+    default:
+        ASSERT_NOT_REACHED();
+        return 0;
+    }
+}
+
+
 PassRefPtr<StyleImage> StyleResolver::loadPendingImage(StylePendingImage* pendingImage)
 {
     CachedResourceLoader* cachedResourceLoader = m_state.document()->cachedResourceLoader();
 
     if (pendingImage->cssImageValue()) {
         CSSImageValue* imageValue = pendingImage->cssImageValue();
         return imageValue->cachedImage(cachedResourceLoader);
     }
 
     if (pendingImage->cssImageGeneratorValue()) {
@@ skipping 167 matching lines @@
     info.addMember(m_state, "state");
 
     // FIXME: move this to a place where it would be called only once?
     info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle");
     info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyle");
     info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle");
     info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSourceStyle");
 }
 
 } // namespace WebCore