[NaCl SDK] nacl_io html5fs: Malformed file paths set errno to ENOENT.

native_client_sdk/src/libraries/nacl_io/mount_html5fs.cc

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "nacl_io/mount_html5fs.h"
 
 #include <errno.h>
 #include <ppapi/c/pp_completion_callback.h>
 #include <ppapi/c/pp_errors.h>
@@ skipping 16 matching lines @@
 Error MountHtml5Fs::Open(const Path& path, int mode, MountNode** out_node) {
   *out_node = NULL;
 
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   PP_Resource fileref = ppapi()->GetFileRefInterface()
       ->Create(filesystem_resource_, path.Join().c_str());
   if (!fileref)
-    return ENOSYS;
+    return ENOENT;
 
   MountNodeHtml5Fs* node = new MountNodeHtml5Fs(this, fileref);
   error = node->Init(mode);
   if (error) {
     node->Release();
     return error;
   }
 
   *out_node = node;
   return 0;
 }
 
 Error MountHtml5Fs::Unlink(const Path& path) { return Remove(path); }
 
 Error MountHtml5Fs::Mkdir(const Path& path, int permissions) {
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   ScopedResource fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
                                              path.Join().c_str()));
   if (!fileref_resource.pp_resource())
     return EIO;

[binji, 2013/06/20 15:56:12]

change this one too? It's not immediately clear what the correct error to return
is (because we don't know why the FileRef create failed) but ENOENT (or ENOTDIR)
is probably better than EIO here.

[Matt Giuca, 2013/06/21 00:33:03]

Yeah it's not quite clear to me what it should be either, but ENOENT seems
appropriate.

 
   int32_t result = ppapi()->GetFileRefInterface()->MakeDirectory(
       fileref_resource.pp_resource(), PP_FALSE, PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPErrorToErrno(result);
 
   return 0;
 }
 
 Error MountHtml5Fs::Rmdir(const Path& path) { return Remove(path); }
 
 Error MountHtml5Fs::Remove(const Path& path) {
   Error error = BlockUntilFilesystemOpen();
   if (error)
     return error;
 
   ScopedResource fileref_resource(
       ppapi(),
       ppapi()->GetFileRefInterface()->Create(filesystem_resource_,
                                              path.Join().c_str()));
   if (!fileref_resource.pp_resource())
-    return ENOSYS;
+    return ENOENT;
 
   int32_t result = ppapi()->GetFileRefInterface()
       ->Delete(fileref_resource.pp_resource(), PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPErrorToErrno(result);
 
   return 0;
 }
 
 MountHtml5Fs::MountHtml5Fs()
@@ skipping 76 matching lines @@
   MountHtml5Fs* self = static_cast<MountHtml5Fs*>(user_data);
   self->FilesystemOpenCallback(result);
 }
 
 void MountHtml5Fs::FilesystemOpenCallback(int32_t result) {
   AutoLock lock(&lock_);
   filesystem_open_has_result_ = true;
   filesystem_open_error_ = PPErrorToErrno(result);
   pthread_cond_signal(&filesystem_open_cond_);
 }