components/autofill/core/browser/autofill_manager.h - Issue 17450010: Create AutofillDriverImpl unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 17450010: Create AutofillDriverImpl unit test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Response to review Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index 0b8345ddfc438a970a5cd1748b14a666b5972071..fc6af7e2bd5e7164dc6f2394ec0cbda582f132ca 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -85,7 +85,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

virtual ~AutofillManager();

// Set an external delegate.

- void SetExternalDelegate(AutofillExternalDelegate* delegate);

+ virtual void SetExternalDelegate(AutofillExternalDelegate* delegate);

Ilya Sherman 2013/06/21 20:19:24 nit: Does this still need to be virtual?

blundell 2013/06/22 06:29:06 Done.

// Whether browser process will create and own the Autofill popup UI.

bool IsNativeUiEnabled();

@@ -184,7 +184,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

const gfx::RectF& bounding_box);

// Resets cache.

- void Reset();

+ virtual void Reset();

protected:

// Test code should prefer to use this constructor.