Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/autofill/content/browser/autofill_driver_impl.h

Issue 17450010: Create AutofillDriverImpl unit test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/autofill_driver_impl.h
diff --git a/components/autofill/content/browser/autofill_driver_impl.h b/components/autofill/content/browser/autofill_driver_impl.h
index b57729328b22dd0871937934037d9396aa5274f7..6c43f9ba62505d87cca460d9c09fd612aa5cf28d 100644
--- a/components/autofill/content/browser/autofill_driver_impl.h
+++ b/components/autofill/content/browser/autofill_driver_impl.h
@@ -54,9 +54,9 @@ class AutofillDriverImpl : public AutofillDriver,
void SetAutofillExternalDelegate(
scoped_ptr<AutofillExternalDelegate> delegate);
- AutofillManager* autofill_manager() { return &autofill_manager_; }
+ AutofillManager* autofill_manager() { return autofill_manager_.get(); }
- private:
+ protected:
AutofillDriverImpl(
content::WebContents* web_contents,
autofill::AutofillManagerDelegate* delegate,
@@ -71,13 +71,18 @@ class AutofillDriverImpl : public AutofillDriver,
const content::FrameNavigateParams& params) OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ // Sets the manager to |manager|. Takes ownership of |manager|.
Ilya Sherman 2013/06/21 20:19:24 nit: Please document that the manager's external d
blundell 2013/06/22 06:29:06 Done.
+ void SetAutofillManager(scoped_ptr<AutofillManager> manager);
+
+ private:
+
Ilya Sherman 2013/06/21 20:19:24 nit: Spurious newline.
blundell 2013/06/22 06:29:06 Done.
// AutofillExternalDelegate instance that this object instantiates in the
// case where the autofill native UI is enabled.
scoped_ptr<AutofillExternalDelegate> autofill_external_delegate_;
// AutofillManager instance via which this object drives the shared Autofill
// code.
- AutofillManager autofill_manager_;
+ scoped_ptr<AutofillManager> autofill_manager_;
};
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698