third_party/WebKit/Source/core/workers/InProcessWorkerBase.h - Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerBase.h

Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/AbstractWorker.cpp ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp » ('j') | third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerBase.h

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h

index 94818b629aa51aba4d8e692c3a822515c070ae09..0d6e76e16b77956ad7837a686ed073582f708609 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h

@@ -6,7 +6,7 @@

#define InProcessWorkerBase_h

#include "core/CoreExport.h"

-#include "core/dom/ActiveDOMObject.h"

+#include "core/dom/ContextLifecycleObserver.h"

#include "core/dom/MessagePort.h"

#include "core/events/EventListener.h"

#include "core/events/EventTarget.h"

@@ -33,8 +33,7 @@ public:

void postMessage(ExecutionContext*, PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, ExceptionState&);

void terminate();

- // ActiveDOMObject

- void stop() override;

+ void contextDestroyed() override;

bool hasPendingActivity() const override;

kinuko 2016/02/29 09:33:52 Can we keep a brief comment for overriding methods

haraken 2016/02/29 10:52:47 Done.

ContentSecurityPolicy* contentSecurityPolicy();