Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 174493003: Move destruction of WebRtcLogUploader to post threads teardown. (Closed)

Created:
6 years, 10 months ago by Henrik Grunell
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Move destruction of WebRtcLogUploader to post threads teardown. Needs to outlive the file thread. Fixes rare crash. BUG=344892 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253551

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Henrik Grunell
6 years, 10 months ago (2014-02-21 15:15:47 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-21 17:06:30 UTC) #2
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-26 08:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/174493003/50001
6 years, 10 months ago (2014-02-26 08:28:55 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 19:29:25 UTC) #5
Message was sent while issue was closed.
Change committed as 253551

Powered by Google App Engine
This is Rietveld 408576698