Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 174493002: Rename base_untrusted to base_nacl (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org, feature-media-reviews_chromium.org, erikwright+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -93 lines) Patch
A + base/base_nacl.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
D base/base_untrusted.gyp View 1 chunk +0 lines, -71 lines 0 comments Download
M components/tracing_untrusted.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/command_buffer_nacl.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu_nacl.gyp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_untrusted.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/media_nacl.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ppapi/ppapi_ipc_untrusted.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared_untrusted.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Sergey Ulanov
6 years, 10 months ago (2014-02-20 23:35:55 UTC) #1
brettw
lgtm
6 years, 10 months ago (2014-02-20 23:39:02 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-21 02:19:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174493002/1
6 years, 10 months ago (2014-02-21 02:20:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:20:16 UTC) #5
commit-bot: I haz the power
Failed to apply patch for gpu/command_buffer/command_buffer_untrusted.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 10 months ago (2014-02-21 02:20:16 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-21 21:42:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174493002/540001
6 years, 10 months ago (2014-02-21 21:45:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:03:37 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=51491 Try jobs failed on ...
6 years, 10 months ago (2014-02-21 22:03:37 UTC) #10
Sergey Ulanov
+ben@ in TBR
6 years, 10 months ago (2014-02-22 00:44:28 UTC) #11
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 10 months ago (2014-02-22 00:44:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/174493002/540001
6 years, 10 months ago (2014-02-22 00:44:55 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 00:48:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-22 00:48:13 UTC) #15
Sergey Ulanov
6 years, 10 months ago (2014-02-22 02:30:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 manually as r252732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698