Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1744913002: Subzero: Add "-verbose init" to control global initializer dumping. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add "-verbose init" to control global initializer dumping. One is rarely interested in seeing dump output regarding global initializers, so we add an additional verbose flag, and don't include it in the "-verbose most" set. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b6dcf3c51dd2ce15efa5717eaca20da1a9071fa2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Naming changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M Makefile.standalone-help/check-lit.txt View 1 chunk +1 line, -1 line 0 comments Download
M pydir/run-pnacl-sz.py View 1 1 chunk +1 line, -1 line 0 comments Download
M src/IceClFlags.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/IceDefs.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/IceGlobalContext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/globalrelocs.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-02-29 03:41:08 UTC) #3
John
lgtm https://codereview.chromium.org/1744913002/diff/1/src/IceClFlags.cpp File src/IceClFlags.cpp (right): https://codereview.chromium.org/1744913002/diff/1/src/IceClFlags.cpp#newcode339 src/IceClFlags.cpp:339: clEnumValN(Ice::IceV_Init, "init", "Global initializers"), init doesn't really convey ...
4 years, 9 months ago (2016-02-29 15:14:02 UTC) #4
Jim Stichnoth
Committed patchset #2 (id:20001) manually as b6dcf3c51dd2ce15efa5717eaca20da1a9071fa2 (tree was closed).
4 years, 9 months ago (2016-02-29 17:34:09 UTC) #6
Jim Stichnoth
4 years, 9 months ago (2016-02-29 17:39:28 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1744913002/diff/1/src/IceClFlags.cpp
File src/IceClFlags.cpp (right):

https://codereview.chromium.org/1744913002/diff/1/src/IceClFlags.cpp#newcode339
src/IceClFlags.cpp:339: clEnumValN(Ice::IceV_Init, "init", "Global
initializers"),
On 2016/02/29 15:14:02, John wrote:
> init doesn't really convey Global Initializers. ginit?

Changed to global_init / IceV_GlobalInit.

Powered by Google App Engine
This is Rietveld 408576698