Delete and recreate the client plugin if WCS is reloaded.

Delete and recreate the client plugin if WCS is reloaded.

Note that I can't reproduce the problem in the linked bug, but based on
your analysis this seems like it should fix it.

BUG=244103
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207854

[Jamie, 2013-06-20 01:50:26]

ptal

[Sergey Ulanov, 2013-06-20 02:41:52]

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
File remoting/webapp/session_connector.js (right):

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
remoting/webapp/session_connector.js:320:
remoting.wcsSandbox.setOnReady(this.onWcsLoaded_.bind(this));
I think it's better to rename setOnReady() to make it clear that the callback
may be called more than once (e.g. setOnLocalJid()).

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
remoting/webapp/session_connector.js:349: // In some circumstances, the WCS
<iframe> can get reloaded, which results
Would it be better to put this code in onWcsLoaded_()?

[Jamie, 2013-06-20 17:32:20]

ptal

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
File remoting/webapp/session_connector.js (right):

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
remoting/webapp/session_connector.js:320:
remoting.wcsSandbox.setOnReady(this.onWcsLoaded_.bind(this));
On 2013/06/20 02:41:53, Sergey Ulanov wrote:
> I think it's better to rename setOnReady() to make it clear that the callback
> may be called more than once (e.g. setOnLocalJid()).

Done.

https://codereview.chromium.org/17449017/diff/1/remoting/webapp/session_conne...
remoting/webapp/session_connector.js:349: // In some circumstances, the WCS
<iframe> can get reloaded, which results
On 2013/06/20 02:41:53, Sergey Ulanov wrote:
> Would it be better to put this code in onWcsLoaded_()?

Having it immediately before creating the new plugin makes the "only one plugin
at a time" guarantee explicit (if Javascript had dtors, I'd probably put the
removal code there). On the other hand, having it in onWcsLoaded_ better
expresses the "this function might be called more than once, so we'd better
reset to a sane state before continuing" idea. I prefer the former so unless you
feel strongly, I'll leave it as-is.

[Sergey Ulanov, 2013-06-21 00:50:18]

lgtm

[commit-bot: I haz the power, 2013-06-21 00:56:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/17449017/5001

[commit-bot: I haz the power, 2013-06-21 16:31:04]

Change committed as 207854