Issue 17449014: cc: Test cleanup for layer tree pixel tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17449014: cc: Test cleanup for layer tree pixel tests. (Closed)

Created:
7 years, 6 months ago by danakj

Modified:
7 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Test cleanup for layer tree pixel tests. Pass the test type (GL/Software cross Bitmap/Texture) as a parameter to RunPixelTest() instead of having tests set a pair of bools. Forces all tests to specify the test type. R=piman BUG=179896 Depends on: https://codereview.chromium.org/17335011/

Patch Set 1 #

Patch Set 2 : copy-test-enum: remove NONE #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -147 lines)			Patch
M	cc/test/layer_tree_pixel_test.h	View	1	2 chunks	+12 lines, -3 lines	0 comments	Download
M	cc/test/layer_tree_pixel_test.cc	View	1	4 chunks	+32 lines, -18 lines	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_filters.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_masks.cc	View		7 chunks	+19 lines, -17 lines	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_readback.cc	View	1	27 chunks	+62 lines, -103 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Merged to https://codereview.chromium.org/17335011/

Expand Messages | Collapse Messages