Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: Source/core/css/CSSProperty.h

Issue 17448021: Make sure ImmutableStylePropertySet uses the new 16 bits size of StylePropertyMetadata. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/StylePropertySet.h » ('j') | Source/core/css/StylePropertySet.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSProperty.h
diff --git a/Source/core/css/CSSProperty.h b/Source/core/css/CSSProperty.h
index 7b12f9bd1febe05c4fa3cf7e8cec3326fe41a28a..82be79c8d1d7460e73571203736dc68bf226307a 100644
--- a/Source/core/css/CSSProperty.h
+++ b/Source/core/css/CSSProperty.h
@@ -41,6 +41,11 @@ struct StylePropertyMetadata {
{
}
+ StylePropertyMetadata(uint32_t data)
+ {
+ memcpy(this, &data, sizeof(StylePropertyMetadata));
Jeffrey Yasskin 2013/06/21 19:56:27 memcpy is dangerous because of endian-ness issues,
+ }
+
CSSPropertyID shorthandID() const;
unsigned m_propertyID : 10;
Jeffrey Yasskin 2013/06/21 19:56:27 If you change the type of these fields to uint16_t
« no previous file with comments | « no previous file | Source/core/css/StylePropertySet.h » ('j') | Source/core/css/StylePropertySet.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698