Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 17448012: Add SkString::appendU32() and SkString::appendU64() (Closed)

Created:
7 years, 6 months ago by epoger
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add SkString::appendU32() and SkString::appendU64() as needed to re-land r9682 R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9686

Patch Set 1 #

Patch Set 2 : add_cornercase_test_that_works_now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -35 lines) Patch
M include/core/SkString.h View 3 chunks +11 lines, -2 lines 0 comments Download
M src/core/SkString.cpp View 3 chunks +34 lines, -25 lines 0 comments Download
M tests/StringTest.cpp View 1 1 chunk +41 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
7 years, 6 months ago (2013-06-19 18:17:11 UTC) #1
reed1
very readable lgtm
7 years, 6 months ago (2013-06-19 18:25:51 UTC) #2
epoger
7 years, 6 months ago (2013-06-19 18:27:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r9686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698