Use skia::RefPtr to avoid having to manually refcount GraphicsContextState::m_looper.

Source/core/platform/graphics/GraphicsContext.h

 /*
  * Copyright (C) 2003, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008-2009 Torch Mobile, Inc.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 20 matching lines @@
 #include "core/platform/chromium/TraceEvent.h"
 #include "core/platform/graphics/DashArray.h"
 #include "core/platform/graphics/DrawLooper.h"
 #include "core/platform/graphics/FloatRect.h"
 #include "core/platform/graphics/Font.h"
 #include "core/platform/graphics/GraphicsContextAnnotation.h"
 #include "core/platform/graphics/GraphicsContextState.h"
 #include "core/platform/graphics/ImageBuffer.h"
 #include "core/platform/graphics/ImageOrientation.h"
 #include "core/platform/graphics/skia/OpaqueRegionSkia.h"
-
+#include "skia/ext/refptr.h"

[jamesr, 2013/06/19 17:45:26]

this creates a cycle between the chromium and blink repositories, which is bad.
There are a few other places that #include "skia/ext/...", but none for
refptr.h. I think skia::RefPtr is better than any of the types in the skia
repository proper, but probably not enough better to add this complexity.

 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkDevice.h"
 #include "third_party/skia/include/core/SkPaint.h"
 #include "third_party/skia/include/core/SkPath.h"
 #include "third_party/skia/include/core/SkRect.h"
 #include "third_party/skia/include/core/SkRRect.h"
 #include "third_party/skia/include/effects/SkCornerPathEffect.h"
-
-#include <wtf/Noncopyable.h>
-#include <wtf/PassOwnPtr.h>
+#include "wtf/Noncopyable.h"
+#include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
 class ImageBuffer;
 class KURL;
 
 class GraphicsContext {
     WTF_MAKE_NONCOPYABLE(GraphicsContext); WTF_MAKE_FAST_ALLOCATED;
 public:
     enum AntiAliasingMode {
@@ skipping 67 matching lines @@
     Color fillColor() const { return m_state->m_fillColor; }
     void setFillColor(const Color&);
     SkColor effectiveFillColor() const { return m_state->applyAlpha(m_state->m_fillColor.rgb()); }
 
     void setFillPattern(PassRefPtr<Pattern>);
     Pattern* fillPattern() const { return m_state->m_fillPattern.get(); }
 
     void setFillGradient(PassRefPtr<Gradient>);
     Gradient* fillGradient() const { return m_state->m_fillGradient.get(); }
 
-    SkDrawLooper* drawLooper() const { return m_state->m_looper; }
+    SkDrawLooper* drawLooper() const { return m_state->m_looper.get(); }
     SkColor effectiveStrokeColor() const { return m_state->applyAlpha(m_state->m_strokeData.color().rgb()); }
 
     int getNormalizedAlpha() const;
 
     bool getClipBounds(SkRect* bounds) const;
     const SkMatrix& getTotalMatrix() const;
     bool isPrintingDevice() const;
 
     void setShadowsIgnoreTransforms(bool ignoreTransforms) { m_state->m_shadowsIgnoreTransforms = ignoreTransforms; }
     bool shadowsIgnoreTransforms() const { return m_state->m_shadowsIgnoreTransforms; }
@@ skipping 237 matching lines @@
             value = -value;
             isNeg = true;
         }
         if (value >= max)
             value %= max;
         if (isNeg)
             value = -value;
         return value;
     }
 
-    void setDrawLooper(SkDrawLooper* looper) { SkRefCnt_SafeAssign(m_state->m_looper, looper); }
+    void setDrawLooper(SkDrawLooper* looper) { m_state->m_looper = skia::SharePtr(looper); }
 
     // Sets up the common flags on a paint for antialiasing, effects, etc.
     // This is implicitly called by setupPaintFill and setupPaintStroke, but
     // you may wish to call it directly sometimes if you don't want that other
     // behavior.
     void setupPaintCommon(SkPaint*) const;
 
     // Helpers for drawing a focus ring (drawFocusRing)
     void drawOuterPath(const SkPath&, SkPaint&, int);
     void drawInnerPath(const SkPath&, SkPaint&, int);
@@ skipping 61 matching lines @@
     // FIXME: Make this go away: crbug.com/236892
     bool m_updatingControlTints : 1;
     bool m_accelerated : 1;
     bool m_isCertainlyOpaque : 1;
     bool m_printing : 1;
 };
 
 } // namespace WebCore
 
 #endif // GraphicsContext_h