Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1744773002: Support conditional directives in the options file. (Closed)

Created:
4 years, 9 months ago by floitsch
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 3 chunks +12 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 9 months ago (2016-02-27 02:43:38 UTC) #2
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-02-27 16:04:59 UTC) #3
floitsch
4 years, 9 months ago (2016-02-29 13:38:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e17f2b98cf7fb4f9679ed0a2e65c288b9344e8f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698