Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/d8.cc

Issue 1744733002: [Tracing] Remove deprecated AddTraceEvent (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-platform.h ('k') | src/libplatform/default-platform.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index a9902ce56cfce0198ce7ed3f833089e6cbbc7a66..7947c3f96957ba53565eb54ce1751da165b7cf0d 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -140,15 +140,6 @@ class PredictablePlatform : public Platform {
return 0;
}
- // TODO(fmeawad): Remove once all embedders implement the scope version.
- uint64_t AddTraceEvent(char phase, const uint8_t* categoryEnabledFlag,
- const char* name, uint64_t id, uint64_t bind_id,
- int numArgs, const char** argNames,
- const uint8_t* argTypes, const uint64_t* argValues,
- unsigned int flags) override {
- return 0;
- }
-
void UpdateTraceEventDuration(const uint8_t* categoryEnabledFlag,
const char* name, uint64_t handle) override {}
« no previous file with comments | « include/v8-platform.h ('k') | src/libplatform/default-platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698