Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1744723002: DM: dm.json can be missing some final results (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: dm.json can be missing some final results We called JsonWriter::DumpJson() every once in a while, but this did not necssarily wait for offloaded PNG encoding to finish. This means we might have been dropping some DM results for a while now. Fix by one more JsonWriter::DumpJson() call after joining back to the main thread. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744723002 Committed: https://skia.googlesource.com/skia/+/e027f1705eb29560df334bcc02a27e5774277984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M dm/DM.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mtklein
lgtm
4 years, 10 months ago (2016-02-26 23:40:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744723002/1
4 years, 10 months ago (2016-02-26 23:40:12 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 23:53:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e027f1705eb29560df334bcc02a27e5774277984

Powered by Google App Engine
This is Rietveld 408576698