webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h - Issue 17447007: Change WGC3DInProcessCBImpl factories to return a base class pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 17447007: Change WGC3DInProcessCBImpl factories to return a base class pointer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/common/gpu/context_provider_in_process.cc ('k') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

index 88ace20a3e9d506ac3be4d8697443dd82a26cfb4..c095ee804868de6df92d1ac32d0dd5a3de146431 100644

--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

@@ -53,14 +53,12 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl

// instances are created. Default value is false.

static void EnableVirtualizedContext();

- static WebGraphicsContext3DInProcessCommandBufferImpl*

- CreateViewContext(

- const WebKit::WebGraphicsContext3D::Attributes& attributes,

- gfx::AcceleratedWidget window);

- static WebGraphicsContext3DInProcessCommandBufferImpl*

- CreateOffscreenContext(

- const WebKit::WebGraphicsContext3D::Attributes& attributes);

+ static scoped_ptr<WebKit::WebGraphicsContext3D> CreateViewContext(

+ const WebKit::WebGraphicsContext3D::Attributes& attributes,

+ gfx::AcceleratedWidget window);

+ static scoped_ptr<WebKit::WebGraphicsContext3D> CreateOffscreenContext(

+ const WebKit::WebGraphicsContext3D::Attributes& attributes);

static void SetGpuMemoryBufferCreator(GpuMemoryBufferCreator* creator);