webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h - Issue 17447007: Change WGC3DInProcessCBImpl factories to return a base class pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 17447007: Change WGC3DInProcessCBImpl factories to return a base class pointer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/common/gpu/context_provider_in_process.cc ('k') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

index 8715f81ba1c72c82b11a6c05b031c20abe5a8b54..490087ac88d44762f76af0c01a4f6c8fe58af44e 100644

--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

@@ -47,12 +47,12 @@ namespace gpu {

class WEBKIT_GPU_EXPORT WebGraphicsContext3DInProcessCommandBufferImpl

: public NON_EXPORTED_BASE(WebKit::WebGraphicsContext3D) {

public:

- static WebGraphicsContext3DInProcessCommandBufferImpl*

+ static WebKit::WebGraphicsContext3D*

jamesr 2013/06/19 23:07:16 not your fault, but this would be better if it ret

no sievers 2013/06/20 00:43:47 Done.

CreateViewContext(

const WebKit::WebGraphicsContext3D::Attributes& attributes,

gfx::AcceleratedWidget window);

- static WebGraphicsContext3DInProcessCommandBufferImpl*

+ static WebKit::WebGraphicsContext3D*

CreateOffscreenContext(

const WebKit::WebGraphicsContext3D::Attributes& attributes);