Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1744693002: Implement QUIC-based net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basecl
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 1d09da79457183d2a5e19694c20d4d76a432fdec..27fc7c8163f8d1fd98c86901cf07a4c63ba29e80 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -1006,10 +1006,10 @@ int HttpStreamFactoryImpl::Job::DoInitConnection() {
origin_host = origin_url_.host();
ssl_config = &server_ssl_config_;
}
- int rv =
- quic_request_.Request(destination, request_info_.privacy_mode,
- ssl_config->GetCertVerifyFlags(), origin_host,
- request_info_.method, net_log_, io_callback_);
+ int rv = quic_request_.Request(destination, request_info_.privacy_mode,
+ ssl_config->GetCertVerifyFlags(),
+ origin_host, request_info_.method, net_log_,
+ io_callback_, for_bidirectional_);
if (rv == OK) {
using_existing_quic_session_ = true;
} else {
@@ -1247,7 +1247,15 @@ int HttpStreamFactoryImpl::Job::DoInitConnectionComplete(int result) {
MaybeMarkAlternativeServiceBroken();
return result;
}
- stream_ = quic_request_.ReleaseStream();
+ if (for_bidirectional_) {
+#if BUILDFLAG(ENABLE_BIDIRECTIONAL_STREAM)
+ bidirectional_stream_job_ = quic_request_.ReleaseBidirectionalStreamJob();
+#else
+ NOTREACHED();
+#endif
+ } else {
+ stream_ = quic_request_.ReleaseStream();
+ }
next_state_ = STATE_NONE;
return OK;
}

Powered by Google App Engine
This is Rietveld 408576698