Expose LibraryElementImpl.libraryCycle through LibraryElement.

Expose LibraryElementImpl.libraryCycle through LibraryElement.

This ensures that `libraryCycle` will work properly when accessing an
element model resynthesized from summaries.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/5b78ff96b3b9aff14c6c51e125a3434169f927b3

[Paul Berry, 2016-02-26 21:21:02]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-26 21:36:55]

https://codereview.chromium.org/1744633002/diff/1/pkg/analyzer/lib/dart/eleme...
File pkg/analyzer/lib/dart/element/element.dart (right):

https://codereview.chromium.org/1744633002/diff/1/pkg/analyzer/lib/dart/eleme...
pkg/analyzer/lib/dart/element/element.dart:1331: List<LibraryElement> get
libraryCycle;
This doesn't feel like a property to me, it feels like a computation, so I think
it would be better represented as a method.

[Brian Wilkerson, 2016-02-26 21:55:43]

After off-line discussion, LGTM

[Paul Berry, 2016-02-26 22:03:28]

Description was changed from

==========
Expose LibraryElementImpl.libraryCycle through LibraryElement.

This ensures that `libraryCycle` will work properly when accessing an
element model resynthesized from summaries.
==========

to

==========
Expose LibraryElementImpl.libraryCycle through LibraryElement.

This ensures that `libraryCycle` will work properly when accessing an
element model resynthesized from summaries.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5b78ff96b3b9aff14c6c51e125a3434169f927b3
==========

[Paul Berry, 2016-02-26 22:03:30]

Committed patchset #1 (id:1) manually as
5b78ff96b3b9aff14c6c51e125a3434169f927b3 (presubmit successful).