Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(228)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/app_forbidden_apis/document_apis/background.js
Issue
1744623002
:
[Extensions] Update web API cloberring for platform apps (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Patch Set:
Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/app_window_overrides_browsertest.cc
chrome/chrome_tests.gypi
chrome/test/data/extensions/app_forbidden_apis/document_apis/background.js
chrome/test/data/extensions/app_forbidden_apis/document_apis/manifest.json
chrome/test/data/extensions/app_forbidden_apis/onbeforeunload/background.js
chrome/test/data/extensions/app_forbidden_apis/onbeforeunload/manifest.json
chrome/test/data/extensions/platform_apps/restrictions/main.js
extensions/renderer/resources/platform_app.js
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/chrome_tests.gypi
('k') |
chrome/test/data/extensions/app_forbidden_apis/document_apis/manifest.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
'use strict';
6
7
var writeSuccess = true;
8
try {
9
Document.prototype.write.call(document, 'Hello, world');
10
} catch (e) {
11
writeSuccess = false;
12
}
13
14
if (writeSuccess)
15
chrome.test.fail();
16
else
17
chrome.test.succeed();
OLD
NEW
« no previous file with comments
|
« chrome/chrome_tests.gypi
('k') |
chrome/test/data/extensions/app_forbidden_apis/document_apis/manifest.json »
('j') |
no next file with comments »
Issue 1744623002: [Extensions] Update web API cloberring for platform apps (Closed)
Created 4 years, 10 months ago by Devlin
Modified 4 years, 10 months ago
Reviewers:
Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 1744623002:
[Extensions] Update web API cloberring for platform apps (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@2623