Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1744623002: [Extensions] Update web API cloberring for platform apps (Closed)

Created:
3 years, 7 months ago by Devlin
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update web API cloberring for platform apps Platform App clobbering for certain Web APIs was incomplete. Make it more complete. See bug for more details. BUG=585282 Review URL: https://codereview.chromium.org/1716513002 Cr-Commit-Position: refs/heads/master@{#376784} (cherry picked from commit dc42ae208c2744f7fb144b2e396358a1fc34db87) Committed: https://chromium.googlesource.com/chromium/src/+/8e79fe67a8b03291c6acac311ed4ca6592798b6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -17 lines) Patch
A chrome/browser/extensions/app_window_overrides_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/app_forbidden_apis/document_apis/background.js View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_forbidden_apis/document_apis/manifest.json View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_forbidden_apis/onbeforeunload/background.js View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/app_forbidden_apis/onbeforeunload/manifest.json View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/main.js View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/resources/platform_app.js View 6 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
3 years, 7 months ago (2016-02-26 20:10:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e79fe67a8b03291c6acac311ed4ca6592798b6f.

Powered by Google App Engine
This is Rietveld 408576698