Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1744613003: Fixed more sdk/lib issues (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed more sdk/lib issues - SpeechRecognition calling blink constructor needs name prefixed with WebKit - Enumerator types as arguments must be String (all enums in IDL are string values). - Removed methods in IDBStorage that caused overloaded operations. TBR=alanknight@google.com, jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/e4b800845b42381da08a1eac9f906d7ebb12a2a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -77 lines) Patch
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/dartgenerator.py View 2 chunks +10 lines, -2 lines 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 1 chunk +72 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
terry
4 years, 9 months ago (2016-02-27 18:44:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4b800845b42381da08a1eac9f906d7ebb12a2a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698