Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1744613002: DevTools: Tweak timeline group headers drawing (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Tweak timeline group headers drawing Make arrow color match other expansion arrows. Align arrows vertically Align title background horizontally Reduce distance between groups. Committed: https://crrev.com/655e7621595620fe75a4ab7d21ecd797729a097a Cr-Commit-Position: refs/heads/master@{#378017}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 3 chunks +11 lines, -14 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
alph
ptal. ss: https://drive.google.com/file/d/0B0KylrRHg2UgalljdWZvc2k1cFU/view?usp=sharing
4 years, 10 months ago (2016-02-26 20:23:21 UTC) #2
caseq
lgtm lgtm https://codereview.chromium.org/1744613002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (left): https://codereview.chromium.org/1744613002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#oldcode1368 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1368: context.shadowBlur = 10; why?
4 years, 10 months ago (2016-02-26 20:53:24 UTC) #3
alph
https://codereview.chromium.org/1744613002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (left): https://codereview.chromium.org/1744613002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#oldcode1368 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1368: context.shadowBlur = 10; On 2016/02/26 20:53:24, caseq wrote: > ...
4 years, 10 months ago (2016-02-26 21:04:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744613002/1
4 years, 10 months ago (2016-02-26 21:08:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 23:10:02 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 23:12:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/655e7621595620fe75a4ab7d21ecd797729a097a
Cr-Commit-Position: refs/heads/master@{#378017}

Powered by Google App Engine
This is Rietveld 408576698