Splitting media router browser tests into separate test cases.

Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177, 582649
R=apacible@chromium.org,imcheng@chromium.org

Committed: https://crrev.com/0425d9e2f7a431cc01e849a885966e5d079df0c3
Cr-Commit-Position: refs/heads/master@{#378034}

[imcheng, 2016-02-26 21:56:42]

lgtm + 1 nit.

Thanks!

https://codereview.chromium.org/1744563003/diff/1/chrome/test/data/webui/medi...
File chrome/test/data/webui/media_router/media_router_elements_browsertest.js
(right):

https://codereview.chromium.org/1744563003/diff/1/chrome/test/data/webui/medi...
chrome/test/data/webui/media_router/media_router_elements_browsertest.js:43:
TEST_F('MediaRouterElementsBrowserTest', 'MediaRouterElementsTestIssue',
naming suggestion: IssueBanner. Similarly for below.

[apacible, 2016-02-26 22:02:40]

lgtm thanks!

Also add crbug/582649 to BUG= in the description.

https://codereview.chromium.org/1744563003/diff/1/chrome/test/data/webui/medi...
File chrome/test/data/webui/media_router/media_router_elements_browsertest.js
(right):

https://codereview.chromium.org/1744563003/diff/1/chrome/test/data/webui/medi...
chrome/test/data/webui/media_router/media_router_elements_browsertest.js:31: //
List tests for individual elements.
nit: Update this comment since the container's tests are split into container
and container filter.

https://codereview.chromium.org/1744563003/diff/1/chrome/test/data/webui/medi...
chrome/test/data/webui/media_router/media_router_elements_browsertest.js:42: //
Runs all tests.
nit: Remove this comment since tests are separated.

[btolsch, 2016-02-26 22:14:57]

Description was changed from

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177
R=apacible@chromium.org,imcheng@chromium.org
==========

to

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177,582649
R=apacible@chromium.org,imcheng@chromium.org
==========

[btolsch, 2016-02-26 22:15:10]

The CQ bit was checked by btolsch@chromium.org

[btolsch, 2016-02-26 22:15:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, apacible@chromium.org
Link to the patchset: https://codereview.chromium.org/1744563003/#ps20001
(title: "Fixed nits")

[commit-bot: I haz the power, 2016-02-26 22:16:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744563003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744563003/20001

[commit-bot: I haz the power, 2016-02-27 00:12:33]

Description was changed from

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177,582649
R=apacible@chromium.org,imcheng@chromium.org
==========

to

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177,582649
R=apacible@chromium.org,imcheng@chromium.org
==========

[commit-bot: I haz the power, 2016-02-27 00:12:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-27 00:14:01]

Description was changed from

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177,582649
R=apacible@chromium.org,imcheng@chromium.org
==========

to

==========
Splitting media router browser tests into separate test cases.

Tests seem to be timing out occasionally and the container tests especially got
really long. This change puts tests that were already in separate files in
separate logical tests as well as splits up the container tests. The aim is to
lower test runtime to avoid timeouts on the trybots. Container tests were split
according to the somewhat arbitrary boundary of the filter view. So tests
relating to the filter view are now in their own file and test case.

This has fixed the timeout issue locally for both release and debug builds.

BUG=590177,582649
R=apacible@chromium.org,imcheng@chromium.org

Committed: https://crrev.com/0425d9e2f7a431cc01e849a885966e5d079df0c3
Cr-Commit-Position: refs/heads/master@{#378034}
==========

[commit-bot: I haz the power, 2016-02-27 00:14:02]

Patchset 2 (id:??) landed as
https://crrev.com/0425d9e2f7a431cc01e849a885966e5d079df0c3
Cr-Commit-Position: refs/heads/master@{#378034}